Skip to content

chore: Update version to 6.0.69 - #717

Merged
lzwind merged 1 commit into
linuxdeepin:masterfrom
add-uos:master
Jul 30, 2026
Merged

chore: Update version to 6.0.69#717
lzwind merged 1 commit into
linuxdeepin:masterfrom
add-uos:master

Conversation

@add-uos

@add-uos add-uos commented Jul 30, 2026 •
edited by sourcery-ai Bot
Loading

Copy link
Copy Markdown
Contributor
  • update version to 6.0.69

log: update version to 6.0.69

Summary by Sourcery

Chores:

  • Bump recorded package version to 6.0.69 in the Debian changelog.

@add-uos
chore: Update version to 6.0.69
eaf109d 
- update version to 6.0.69

log: update version to 6.0.69
@sourcery-ai

sourcery-ai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the recorded package version to 6.0.69 in the Debian changelog to reflect the new release.

File-Level Changes

Change Details Files
Bump package version to 6.0.69 in Debian packaging metadata.
  • Update the latest entry in the Debian changelog to set the version to 6.0.69.
  • Ensure the changelog log message reflects the new 6.0.69 version.
 debian/changelog
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown

TAG Bot

TAG: 6.0.69
EXISTED: no
DISTRIBUTION: unstable

sourcery-ai[bot]
sourcery-ai Bot reviewed Jul 30, 2026
View reviewed changes

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

deepin-ci-robot commented Jul 30, 2026

Copy link
Copy Markdown

deepin pr auto review

★ 总体评分：95分

■ 【总体评价】

代码通过直接比较原始字节数修复了本地化字符串解析导致的存储设备大小比较错误问题
逻辑正确且修复了核心缺陷，代码简洁高效，无安全漏洞

■ 【详细分析】

  • 1.语法逻辑完全正确✓

DeviceManager::compareStorageSize 函数返回 d1.sizeBytes > d2.sizeBytes，直接比较字节数，语法正确，逻辑清晰，彻底解决了因本地化浮点数字符串（如逗号分隔符）导致 toFloat() 失败的问题。
潜在问题：无
建议：无需修改

  • 2.代码质量良好✓

代码极其简洁，去除了不必要的字符串转换逻辑，直接使用底层数据结构 sizeBytes 进行比较，可读性强。
潜在问题：如果 DeviceInfo 结构中不存在 sizeBytes 字段或该字段未被正确赋值，可能导致比较结果不正确。
建议：确保在解析设备信息时，sizeBytes 字段被正确填充为设备实际大小的字节数。

  • 3.代码性能高效✓

直接进行整数/长整型比较，避免了字符串解析和浮点数转换的开销，性能最优。
潜在问题：无
建议：无需修改

  • 4.代码安全存在0个安全漏洞✓

漏洞对比统计：新增漏洞 0 个，减少漏洞 0 个，持平 0 个
该修改仅涉及数值比较逻辑的优化，不涉及外部输入处理、内存操作或权限校验，不存在安全风险。

  • 建议：无需安全修复

■ 【改进建议代码示例】

// 当前代码已是最优实现，无需修改
bool DeviceManager::compareStorageSize(const DeviceInfo &d1, const DeviceInfo &d2) 
{
    // 直接比较原始字节数，避免本地化字符串导致的解析错误
    return d1.sizeBytes > d2.sizeBytes;
}

@deepin-ci-robot

deepin-ci-robot commented Jul 30, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lzwind
lzwind merged commit 6352127 into linuxdeepin:master Jul 30, 2026
21 checks passed
@deepin-bot

deepin-bot Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

TAG Bot

✅ Tag created successfully

📋 Tag Details
  • Tag Name: 6.0.69
  • Tag SHA: a92ecebc7d0888d31bc304e3d1c0c9849bf66aac
  • Commit SHA: 6352127ceeba10c75e5f8ac6718b421fa178926f
  • Tag Message: 
    Release deepin-devicemanager 6.0.69
  • Tagger:
    • Name: add-uos
  • Distribution: unstable

@deepin-bot deepin-bot Bot mentioned this pull request Jul 30, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments
@lzwind lzwind lzwind approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@add-uos @deepin-ci-robot @lzwind